netdev - Re: [PATCH net-next v1 3/3] bnxt_en: only set dev->queue_mgmt_ops if BNXT_SUPPORTS_NTUPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ae97740-0a1b-4099-bbfb-1d4b783c6be5@intel.com>
Date: Tue, 30 Jul 2024 12:33:40 +0200
From: Wojciech Drewek <wojciech.drewek@...el.com>
To: David Wei <dw@...idwei.uk>, <netdev@...r.kernel.org>
CC: Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, "Michael
 Chan" <michael.chan@...adcom.com>
Subject: Re: [PATCH net-next v1 3/3] bnxt_en: only set dev->queue_mgmt_ops if
 BNXT_SUPPORTS_NTUPLE_VNIC



On 29.07.2024 22:54, David Wei wrote:
> The queue API calls bnxt_hwrm_vnic_update() to stop/start the flow of
> packets. It can only be called if BNXT_SUPPORTS_NTUPLE_VNIC(), so key
> support for it by only setting queue_mgmt_ops if this is true.
> 
> Signed-off-by: David Wei <dw@...idwei.uk>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>

>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index ce60c9322fe6..2801ae94d87b 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -15713,7 +15713,6 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	dev->stat_ops = &bnxt_stat_ops;
>  	dev->watchdog_timeo = BNXT_TX_TIMEOUT;
>  	dev->ethtool_ops = &bnxt_ethtool_ops;
> -	dev->queue_mgmt_ops = &bnxt_queue_mgmt_ops;
>  	pci_set_drvdata(pdev, dev);
>  
>  	rc = bnxt_alloc_hwrm_resources(bp);
> @@ -15892,8 +15891,10 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  
>  	INIT_LIST_HEAD(&bp->usr_fltr_list);
>  
> -	if (BNXT_SUPPORTS_NTUPLE_VNIC(bp))
> +	if (BNXT_SUPPORTS_NTUPLE_VNIC(bp)) {
>  		bp->rss_cap |= BNXT_RSS_CAP_MULTI_RSS_CTX;
> +		dev->queue_mgmt_ops = &bnxt_queue_mgmt_ops;
> +	}
>  
>  	rc = register_netdev(dev);
>  	if (rc)