netdev - Re: [PATCH] wifi: plfxlc: remove assert for mac->lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877cd39nhg.fsf@kernel.org>
Date: Tue, 30 Jul 2024 13:35:07 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Edward Adam Davis <eadavis@...com>
Cc: syzbot+51a42f7c2e399392ea82@...kaller.appspotmail.com,
  linux-kernel@...r.kernel.org,  linux-usb@...r.kernel.org,
  linux-wireless@...r.kernel.org,  netdev@...r.kernel.org,
  srini.raju@...elifi.com,  syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] wifi: plfxlc: remove assert for mac->lock

Edward Adam Davis <eadavis@...com> writes:

> syzbot report WARNING in plfxlc_mac_release, according to the context,
> there is not need assert for mac->lock.

The commit message should explain _why_ the assert is not needed.
Otherwise it looks that you are randomly removing it to get rid of the
warning.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches