netdev - Re: [PATCH RFC] can: m_can: Release irq on error in m_can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240730-slick-ochre-saluki-13bd13-mkl@pengutronix.de>
Date: Tue, 30 Jul 2024 13:17:47 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Simon Horman <horms@...nel.org>
Cc: Chandrasekar Ramakrishnan <rcsekar@...sung.com>, 
	Vincent Mailhol <mailhol.vincent@...adoo.fr>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Vivek Yadav <vivek.2311@...sung.com>, linux-can@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH RFC] can: m_can: Release irq on error in m_can_open

On 30.07.2024 12:12:21, Simon Horman wrote:
> It appears that the irq requested in m_can_open() may be leaked
> if an error subsequently occurs: if m_can_start() fails.
> 
> Address this by calling free_irq in the unwind path for
> such cases.
> 
> Flagged by Smatch.
> Compile tested only.
> 
> Fixes: eaacfeaca7ad ("can: m_can: Call the RAM init directly from m_can_chip_config")
> Signed-off-by: Simon Horman <horms@...nel.org>

Looks good to me!

Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)