netdev - Re: [Intel-wired-lan] [PATCH iwl-next v8 08/14] iavf: periodically cache PHC time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7143375-194d-4c75-8e60-9734a09580c7@intel.com>
Date: Tue, 30 Jul 2024 15:49:46 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>, Jacob Keller
	<jacob.e.keller@...el.com>, Wojciech Drewek <wojciech.drewek@...el.com>,
	Simon Horman <horms@...nel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v8 08/14] iavf: periodically
 cache PHC time

From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
Date: Tue, 30 Jul 2024 05:15:03 -0400

> From: Jacob Keller <jacob.e.keller@...el.com>
> 
> The Rx timestamps reported by hardware may only have 32 bits of storage
> for nanosecond time. These timestamps cannot be directly reported to the
> Linux stack, as it expects 64bits of time.

[...]

> +static void iavf_ptp_cache_phc_time(struct iavf_adapter *adapter)
> +{
> +	if (time_is_before_jiffies(adapter->ptp.cached_phc_updated + HZ)) {
> +		/* The response from virtchnl will store the time into
> +		 * cached_phc_time

Minor, but a period at the end of the sentence is needed.

> +		 */
> +		iavf_send_phc_read(adapter);
> +	}
> +}

Thanks,
Olek