netdev - Re: [PATCH v2 net-next resent] net: fec: Enable SOC specific rx-usecs coalescence default setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5A7BcFpMFQ_4wtQ5s8cVpUhCKMXScKkYvhq9gkrCQ3uEQ@mail.gmail.com>
Date: Tue, 30 Jul 2024 11:24:40 -0300
From: Fabio Estevam <festevam@...il.com>
To: Joe Damato <jdamato@...tly.com>, Shenwei Wang <shenwei.wang@....com>, 
	Wei Fang <wei.fang@....com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Clark Wang <xiaoning.wang@....com>, imx@...ts.linux.dev, netdev@...r.kernel.org, 
	linux-imx@....com
Cc: Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v2 net-next resent] net: fec: Enable SOC specific rx-usecs
 coalescence default setting

On Tue, Jul 30, 2024 at 7:17 AM Joe Damato <jdamato@...tly.com> wrote:

> I'm not sure this short paragraph addresses Andrew's comment:
>
>   Have you benchmarked CPU usage with this patch, for a range of traffic
>   bandwidths and burst patterns. How does it differ?
>
> Maybe you could provide more details of the iperf tests you ran? It
> seems odd that CPU usage is unchanged.
>
> If the system is more reactive (due to lower coalesce settings and
> IRQs firing more often), you'd expect CPU usage to increase,
> wouldn't you?

[Added Andrew on Cc]

Shenwei,

If someone comments on a previous version of the path,
it is good practice to copy the person on subsequent versions.