netdev - RE: net: xilinx: axienet: Query about checksum partial implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN0PR12MB59534F7030FB73002F1223F4B7B02@MN0PR12MB5953.namprd12.prod.outlook.com>
Date: Tue, 30 Jul 2024 19:15:13 +0000
From: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
To: Simon Horman <horms@...nel.org>
CC: Daniel Borkmann <daniel@...earbox.net>, Ariane Keller
	<ariane.keller@....ee.ethz.ch>, "Simek, Michal" <michal.simek@....com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "Katakam, Harini"
	<harini.katakam@....com>
Subject: RE: net: xilinx: axienet: Query about checksum partial implementation

> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Friday, July 26, 2024 5:37 PM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@....com>
> Cc: Daniel Borkmann <daniel@...earbox.net>; Ariane Keller
> <ariane.keller@....ee.ethz.ch>; Simek, Michal <michal.simek@....com>;
> netdev@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> Subject: net: xilinx: axienet: Query about checksum partial implementation
> 
> Hi Radhey, all,
> 
> I am wondering if you could shed some light on the following checksum
> partial handling in the axienet_rx_poll():
> 
>                         /* if we're doing Rx csum offload, set it up */
>                         if (lp->features & XAE_FEATURE_FULL_RX_CSUM) {
> 				...
>                         } else if ((lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) != 0
> &&
>                                    skb->protocol == htons(ETH_P_IP) &&
>                                    skb->len > 64) {
>                                 skb->csum = be32_to_cpu(cur_p->app3 & 0xFFFF);
>                                 ...
>                         }
> 
> In particluar the "skb->csum =" line.
> 
> The type of cur_p->app3 is u32, and 0xFFFF is also host byte order.
> So far so good. But after the bitwise operation it is treated as a big-endian
> value by passing it to be32_to_cpu.
> 
> Perhaps I am missing something obvious, but my question is how does that
> work?
> 
> * Was it only tested on big endian sysgtems where be32_to_cpu() is a no-op
> 
> * Was it only tested on little endian systems where be32_to_cpu()
>   is a byteswap and somehow that works (how?).
> 
> * Is the code unecessised because the XAE_FEATURE_FULL_RX_CSUM branch
> is
>   always taken?
> 
>   A grep of dts files shows up arch/microblaze/boot/dts/system.dts which
>   sets sets xlnx,rxcsum to 0, which corresponds to XAE_NO_CSUM_OFFLOAD.

+ Harini

Yes, IIRC default AXI Ethernet IP RX checksum is set to "No checksum offload"
so, it is default case and being set in most designs. Have added Harini to this
thread to confirm on partial checksum verification results.

Assuming partial implementation is functional then likely DMA IP updates
application field in big endian format and that is the reason we have this
be32 to CPU conversion in place. will dig a bit more and get back on it.

> 
> * Something else
> 
> Flagged by Sparse
> 
> The in quesoitn code seems to have been introduced by 8a3b7a252dca
> ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
>