netdev - Re: [net-next v3 14/15] net: marvell: Convert tasklet API to new bottom half workqueue mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbb19744-cc77-4541-90b5-0760e0eeae22@lunn.ch>
Date: Tue, 30 Jul 2024 22:39:51 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Allen Pais <allen.lkml@...il.com>
Cc: kuba@...nel.org, Marcin Wojtas <marcin.s.wojtas@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Mirko Lindner <mlindner@...vell.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	jes@...ined-monkey.org, kda@...ux-powerpc.org,
	cai.huoqing@...ux.dev, dougmill@...ux.ibm.com, npiggin@...il.com,
	christophe.leroy@...roup.eu, aneesh.kumar@...nel.org,
	naveen.n.rao@...ux.ibm.com, nnac123@...ux.ibm.com,
	tlfalcon@...ux.ibm.com, cooldavid@...ldavid.org, nbd@....name,
	sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
	lorenzo@...nel.org, matthias.bgg@...il.com,
	angelogioacchino.delregno@...labora.com, borisp@...dia.com,
	bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com,
	louis.peens@...igine.com, richardcochran@...il.com,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-acenic@...site.dk, linux-net-drivers@....com,
	netdev@...r.kernel.org
Subject: Re: [net-next v3 14/15] net: marvell: Convert tasklet API to new
 bottom half workqueue mechanism

> - * Called only from mvpp2_txq_done(), called from mvpp2_tx()
> - * (migration disabled) and from the TX completion tasklet (migration
> - * disabled) so using smp_processor_id() is OK.
> + * Called only from mvpp2_txq_done().
> + *
> + * Historically, this function was invoked directly from mvpp2_tx()
> + * (with migration disabled) and from the bottom half workqueue.
> + * Verify that the use of smp_processor_id() is still appropriate
> + * considering the current bottom half workqueue implementation.

What does this mean? You want somebody else to verify this? You are
potentially breaking this driver?

	Andrew