netdev - Re: [PATCH v5 4/5] wifi: brcmfmac: Add optional lpo clock enable support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYZPR03MB70010073A25C8C3D67ED47DF80B02@TYZPR03MB7001.apcprd03.prod.outlook.com>
Date: Tue, 30 Jul 2024 23:57:28 +0000
From: Jacobe Zang <jacobe.zang@...ion.com>
To: Arend van Spriel <arend.vanspriel@...adcom.com>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"heiko@...ech.de" <heiko@...ech.de>, "kvalo@...nel.org" <kvalo@...nel.org>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>
CC: "efectn@...tonmail.com" <efectn@...tonmail.com>, "dsimic@...jaro.org"
	<dsimic@...jaro.org>, "jagan@...eble.ai" <jagan@...eble.ai>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-rockchip@...ts.infradead.org"
	<linux-rockchip@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "arend@...adcom.com" <arend@...adcom.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "megi@....cz"
	<megi@....cz>, "duoming@....edu.cn" <duoming@....edu.cn>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>, "minipli@...ecurity.net"
	<minipli@...ecurity.net>, "brcm80211@...ts.linux.dev"
	<brcm80211@...ts.linux.dev>, "brcm80211-dev-list.pdl@...adcom.com"
	<brcm80211-dev-list.pdl@...adcom.com>, Nick Xie <nick@...das.com>
Subject: Re: [PATCH v5 4/5] wifi: brcmfmac: Add optional lpo clock enable
 support

>> WiFi modules often require 32kHz clock to function. Add support to
>> enable the clock to PCIe driver.
>>
>> Co-developed-by: Ondrej Jirman <megi@....cz>
>> Signed-off-by: Ondrej Jirman <megi@....cz>
>> Signed-off-by: Jacobe Zang <jacobe.zang@...ion.com>
>> ---
>>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
>> index e406e11481a62..6246e3fd7399f 100644
>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c
>> @@ -6,6 +6,7 @@
>>   #include <linux/of.h>
>>   #include <linux/of_irq.h>
>>   #include <linux/of_net.h>
>> +#include <linux/clk.h>
>>  
>>   #include <defs.h>
>>   #include "debug.h"
>> @@ -70,6 +71,7 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
>>   {
>>        struct brcmfmac_sdio_pd *sdio = &settings->bus.sdio;
>>        struct device_node *root, *np = dev->of_node;
>> +     struct clk *clk;
>>        const char *prop;
>>        int irq;
>>        int err;
>> @@ -113,6 +115,12 @@ void brcmf_of_probe(struct device *dev, enum brcmf_bus_type bus_type,
>>                of_node_put(root);
>>        }
>>  
>> +     clk = devm_clk_get_optional_enabled(dev, "lpo");
>> +     if (!IS_ERR_OR_NULL(clk)) {
>> +             brcmf_dbg(INFO, "enabling 32kHz clock\n");
>> +             clk_set_rate(clk, 32768);
>> +     }
>> +
>>        if (!np || !of_device_is_compatible(np, "brcm,bcm4329-fmac"))
>>                return;
>
> This if-statement should be the first check in brcmf_of_probe(). Can you
> include that change in your patch.

Sure. I will change it ;-)


---
Best Regards
Jacobe