netdev - Re: [PATCH can-next 19/21] can: rockchip_canfd: add hardware timestamping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240731090416.GP1967603@kernel.org>
Date: Wed, 31 Jul 2024 10:04:16 +0100
From: Simon Horman <horms@...nel.org>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: kernel@...gutronix.de, Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Elaine Zhang <zhangqing@...k-chips.com>,
	David Jander <david.jander@...tonic.nl>, linux-can@...r.kernel.org,
	netdev@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH can-next 19/21] can: rockchip_canfd: add hardware
 timestamping support

On Wed, Jul 31, 2024 at 10:00:41AM +0200, Marc Kleine-Budde wrote:
> On 30.07.2024 17:30:14, Simon Horman wrote:
> > On Mon, Jul 29, 2024 at 03:05:50PM +0200, Marc Kleine-Budde wrote:
> > > Add support for hardware based timestamping.
> > > 
> > > Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
> > 
> > Hi Marc,
> > 
> > This patch seems to break allmodconfig builds on (at least) x86_64
> > when applied to net-next.
> > 
> > In file included from drivers/net/can/rockchip/rockchip_canfd-ethtool.c:9:
> > drivers/net/can/rockchip/rockchip_canfd.h:471:29: error: field 'cc' has incomplete type
> >   471 |         struct cyclecounter cc;
> 
> The required header gets somehow pulled in on arm64, but it even fails
> on arm. Fixed.

Interesting times :)

Thanks for addressing this, and likewise my feedback on other patches
in this series.