netdev - Re: [PATCH net-next 4/6] tcp: rstreason: introduce SK_RST_REASON_TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoDuChRQePz3wXSoSQ-X7MXtAevpTmfaQWthjhqaeQPDJQ@mail.gmail.com>
Date: Wed, 31 Jul 2024 08:02:11 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com, 
	kernelxing@...cent.com, kuba@...nel.org, netdev@...r.kernel.org, 
	pabeni@...hat.com
Subject: Re: [PATCH net-next 4/6] tcp: rstreason: introduce
 SK_RST_REASON_TCP_STATE for active reset

Hello Kuniyuki,

On Wed, Jul 31, 2024 at 4:06 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> From: Jason Xing <kerneljasonxing@...il.com>
> Date: Tue, 30 Jul 2024 21:35:11 +0800
> > From: Jason Xing <kernelxing@...cent.com>
> >
> > Introducing a new type TCP_STATE to handle some reset conditions
> > appearing in RFC 793 due to its socket state.
>
> Why not RFC 9293 ?
> Was there any discrepancy ?

Thanks for the review.

My intention is to keep consistency with the comment in
tcp_need_reset(). I have no strong preference here. Either way is fine
with me.

Thanks,
Jason

>
>
> >
> > Signed-off-by: Jason Xing <kernelxing@...cent.com>
> > ---
> >  include/net/rstreason.h | 6 ++++++
> >  net/ipv4/tcp.c          | 4 ++--
> >  net/ipv4/tcp_timer.c    | 2 +-
> >  3 files changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/net/rstreason.h b/include/net/rstreason.h
> > index eef658da8952..fecaa57f1634 100644
> > --- a/include/net/rstreason.h
> > +++ b/include/net/rstreason.h
> > @@ -20,6 +20,7 @@
> >       FN(TCP_ABORT_ON_CLOSE)          \
> >       FN(TCP_ABORT_ON_LINGER)         \
> >       FN(TCP_ABORT_ON_MEMORY)         \
> > +     FN(TCP_STATE)                   \
> >       FN(MPTCP_RST_EUNSPEC)           \
> >       FN(MPTCP_RST_EMPTCP)            \
> >       FN(MPTCP_RST_ERESOURCE)         \
> > @@ -102,6 +103,11 @@ enum sk_rst_reason {
> >        * corresponding to LINUX_MIB_TCPABORTONMEMORY
> >        */
> >       SK_RST_REASON_TCP_ABORT_ON_MEMORY,
> > +     /**
> > +      * @SK_RST_REASON_TCP_STATE: abort on tcp state
> > +      * Please see RFC 793 for all possible reset conditions
> > +      */
> > +     SK_RST_REASON_TCP_STATE,
>
> Same here.