netdev - Re: [PATCH net-next v2 0/3] fix bnxt_en queue reset when queue is active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2dcfb5d-19b5-4c00-89ad-2d63992d8f50@intel.com>
Date: Wed, 31 Jul 2024 15:33:29 +0200
From: Wojciech Drewek <wojciech.drewek@...el.com>
To: David Wei <dw@...idwei.uk>, <netdev@...r.kernel.org>
CC: Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, "Michael
 Chan" <michael.chan@...adcom.com>, Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH net-next v2 0/3] fix bnxt_en queue reset when queue is
 active



On 31.07.2024 15:15, David Wei wrote:
> The current bnxt_en queue API implementation is buggy when resetting a
> queue that has active traffic. The problem is that there is no FW
> involved to stop the flow of packets and relying on napi_disable() isn't
> enough.
> 
> To fix this, call bnxt_hwrm_vnic_update() with MRU set to 0 for both the
> default and the ntuple vnic to stop the flow of packets. This works for
> any Rx queue and not only those that have ntuple rules since every Rx
> queue is either in the default or the ntuple vnic.
> 
> The first patch is from Michael Chan and adds the prerequisite vnic
> functions and definitions.
> 
> Tested on BCM957504 while iperf3 is active:
> 
> 1. Reset a queue that has an ntuple rule steering flow into it
> 2. Reset all queues in order, one at a time
> 
> In both cases the flow is not interrupted.
> 
> Sending this to net-next as there is no in-tree kernel consumer of queue
> API just yet, and there is a patch that changes when the queue_mgmt_ops
> is registered.
> 
> ---
> v2:
>  - split setting vnic->mru into a separate patch (Wojciech)
>  - clarify why napi_enable()/disable() is removed

Thanks!
For the whole series:
Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>

Remember to include my tag if next version will be needed :)

> 
> David Wei (3):
>   bnxt_en: set vnic->mru in bnxt_hwrm_vnic_cfg()
>   bnxt_en: stop packet flow during bnxt_queue_stop/start
>   bnxt_en: only set dev->queue_mgmt_ops if BNXT_SUPPORTS_NTUPLE_VNIC
> 
> Michael Chan (1):
>   bnxt_en: Add support to call FW to update a VNIC
> 
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 50 ++++++++++++++++---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  3 ++
>  drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 37 ++++++++++++++
>  3 files changed, 83 insertions(+), 7 deletions(-)
>