netdev - Re: [PATCH v2 ethtool] qsfp: Better handling of Page 03h netlink read failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d232ddce-ec6a-4131-bf47-04ffe5a74557@ans.pl>
Date: Wed, 31 Jul 2024 06:58:08 -0700
From: Krzysztof Olędzki <ole@....pl>
To: Ido Schimmel <idosch@...dia.com>, Michal Kubecek <mkubecek@...e.cz>
Cc: Andrew Lunn <andrew@...n.ch>, Moshe Shemesh <moshe@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>, tariqt@...dia.com,
        Dan Merillat <git@....merillat.org>
Subject: Re: [PATCH v2 ethtool] qsfp: Better handling of Page 03h netlink read
 failure

On 31.07.2024 at 01:20, Ido Schimmel wrote:
> On Tue, Jul 30, 2024 at 05:49:33PM -0700, Krzysztof Olędzki wrote:
>> When dumping the EEPROM contents of a QSFP transceiver module, ethtool
>> will only ask the kernel to retrieve Upper Page 03h if the module
>> advertised it as supported.
>>
>> However, some kernel drivers like mlx4 are currently unable to provide
>> the page, resulting in the kernel returning an error. Since Upper Page
>> 03h is optional, do not treat the error as fatal. Instead, print an
>> error message and allow ethtool to continue and parse / print the
>> contents of the other pages.
>>
>> Also, clarify potentially cryptic "netlink error: Invalid argument" message.
>>
>> Before:
>>  # ethtool -m eth3
>>  netlink error: Invalid argument
>>
>> After:
>>  # ethtool -m eth3
>>  netlink error: Invalid argument
>>  Failed to read Upper Page 03h, driver error?
>>          Identifier                                : 0x0d (QSFP+)
>>          Extended identifier                       : 0x00
>>  (...)
>>
>> Fixes: 25b64c66f58d ("ethtool: Add netlink handler for getmodule (-m)")
>>
> 
> Nit: No blank line between Fixes and SoB, but maybe Michal can fix it up
> when applying

Ah... thanks. :/

Michal, please let me know if I should send a v3 or if you can correct this issue.

Krzysztof