netdev - Re: [PATCH net-next] RDS: IB: Remove unused declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40988b083db40968700c79a752590fe78b640a02.camel@oracle.com>
Date: Wed, 31 Jul 2024 18:31:25 +0000
From: Allison Henderson <allison.henderson@...cle.com>
To: "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
CC: "rds-devel@....oracle.com" <rds-devel@....oracle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] RDS: IB: Remove unused declarations

On Wed, 2024-07-31 at 14:36 +0800, Yue Haibing wrote:
> Commit f4f943c958a2 ("RDS: IB: ack more receive completions to
> improve performance")
> removed rds_ib_recv_tasklet_fn() implementation but not the
> declaration.
> And commit ec16227e1414 ("RDS/IB: Infiniband transport") declared but
> never implemented
> other functions.
> 
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> Reviewed-by: Simon Horman <horms@...nel.org>

Hello Yue,

Thanks for finding these.  The declarations do appear unused, so I
think it is fine to remove them.  Thanks for the clean up.

Reviewed-by: Allison Henderson <allison.henderson@...cle.com>

> ---
>  net/rds/ib.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/net/rds/ib.h b/net/rds/ib.h
> index 2ba71102b1f1..8ef3178ed4d6 100644
> --- a/net/rds/ib.h
> +++ b/net/rds/ib.h
> @@ -369,9 +369,6 @@ int rds_ib_conn_alloc(struct rds_connection
> *conn, gfp_t gfp);
>  void rds_ib_conn_free(void *arg);
>  int rds_ib_conn_path_connect(struct rds_conn_path *cp);
>  void rds_ib_conn_path_shutdown(struct rds_conn_path *cp);
> -void rds_ib_state_change(struct sock *sk);
> -int rds_ib_listen_init(void);
> -void rds_ib_listen_stop(void);
>  __printf(2, 3)
>  void __rds_ib_conn_error(struct rds_connection *conn, const char *,
> ...);
>  int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id,
> @@ -402,7 +399,6 @@ void rds_ib_inc_free(struct rds_incoming *inc);
>  int rds_ib_inc_copy_to_user(struct rds_incoming *inc, struct
> iov_iter *to);
>  void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic, struct
> ib_wc *wc,
>                              struct rds_ib_ack_state *state);
> -void rds_ib_recv_tasklet_fn(unsigned long data);
>  void rds_ib_recv_init_ring(struct rds_ib_connection *ic);
>  void rds_ib_recv_clear_ring(struct rds_ib_connection *ic);
>  void rds_ib_recv_init_ack(struct rds_ib_connection *ic);