netdev - Re: [PATCH v1 net] sctp: Fix null-ptr-deref in reuseport_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d9989bb-b33c-487a-850a-214f82c59672@yandex.ru>
Date: Wed, 31 Jul 2024 22:15:12 +0300
From: Dmitry Antipov <dmantipov@...dex.ru>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 kuni1840@...il.com, linux-sctp@...r.kernel.org, lucien.xin@...il.com,
 marcelo.leitner@...il.com, netdev@...r.kernel.org, pabeni@...hat.com,
 syzbot+e6979a5d2f10ecb700e4@...kaller.appspotmail.com
Subject: Re: [PATCH v1 net] sctp: Fix null-ptr-deref in reuseport_add_sock().

On 7/31/24 10:06 PM, Kuniyuki Iwashima wrote:

> reuseport_lock is to synchronise operations within the same
> reuseport group, but which socket should belong to which group
> is out of scope.

Hm... then the lock should be a member of 'struct sock_reuseport'
rather than global, isn't?

Dmitry