netdev - Re: [PATCH net-next v2] net: pse-pd: tps23881: Fix the device ID check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240731212627.16b1bcf1@windsurf>
Date: Wed, 31 Jul 2024 21:26:27 +0200
From: Thomas Petazzoni <thomas.petazzoni@...tlin.com>
To: Kyle Swenson <kyle.swenson@....tech>
Cc: "o.rempel@...gutronix.de" <o.rempel@...gutronix.de>,
 "kory.maincent@...tlin.com" <kory.maincent@...tlin.com>, "kuba@...nel.org"
 <kuba@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2] net: pse-pd: tps23881: Fix the device ID
 check

On Wed, 31 Jul 2024 15:42:14 +0000
Kyle Swenson <kyle.swenson@....tech> wrote:

> The DEVID register contains two pieces of information: the device ID in
> the upper nibble, and the silicon revision number in the lower nibble.
> The driver should work fine with any silicon revision, so let's mask
> that out in the device ID check.
> 
> Fixes: 20e6d190ffe1 ("net: pse-pd: Add TI TPS23881 PSE controller driver")
> Signed-off-by: Kyle Swenson <kyle.swenson@....tech>

Thanks for the change!

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@...tlin.com>

-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com