netdev - Re: [PATCH net-next v2 2/5] net: dsa: microchip: move KSZ9477 WoL functions to ksz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240731201038.GT1967603@kernel.org>
Date: Wed, 31 Jul 2024 21:10:38 +0100
From: Simon Horman <horms@...nel.org>
To: vtpieter@...il.com
Cc: devicetree@...r.kernel.org, woojung.huh@...rochip.com,
	UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org,
	o.rempel@...gutronix.de,
	Pieter Van Trappen <pieter.van.trappen@...n.ch>
Subject: Re: [PATCH net-next v2 2/5] net: dsa: microchip: move KSZ9477 WoL
 functions to ksz_common

On Wed, Jul 31, 2024 at 12:34:00PM +0200, vtpieter@...il.com wrote:
> From: Pieter Van Trappen <pieter.van.trappen@...n.ch>
> 
> Move KSZ9477 WoL functions to ksz_common, in preparation for adding
> KSZ87xx family support.
> 
> Signed-off-by: Pieter Van Trappen <pieter.van.trappen@...n.ch>

Hi Pieter,

This is not a full review, and I suggest waiting for feedback from others.

However, I think this patch-set needs to be re-arranged a little,
perhaps by bringing forward some of the header file changes
in the following patch forward, either into this patch
or a new patch before it.

In any case, the driver does not compile with this patch applied,
f.e. W=1 build using allmodconfig on x86_64. While it does
compile just fine when the following patch is applied.

-- 
pw-bot: changes-requested