netdev - RE: [PATCH v4 2/4] net: stmmac: dwc-qos: Add FSD EQoS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00b201dae303$85f58c80$91e0a580$@samsung.com>
Date: Wed, 31 Jul 2024 10:08:38 +0530
From: "Swathi K S" <swathi.ks@...sung.com>
To: "'Andrew Lunn'" <andrew@...n.ch>
Cc: <krzk@...nel.org>, <robh@...nel.org>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<conor+dt@...nel.org>, <richardcochran@...il.com>,
	<mcoquelin.stm32@...il.com>, <alim.akhtar@...sung.com>,
	<linux-fsd@...la.com>, <netdev@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-stm32@...md-mailman.stormreply.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-samsung-soc@...r.kernel.org>,
	<alexandre.torgue@...s.st.com>, <peppe.cavallaro@...com>,
	<joabreu@...opsys.com>, <rcsekar@...sung.com>, <ssiddha@...la.com>,
	<jayati.sahu@...sung.com>, <pankaj.dubey@...sung.com>,
	<ravi.patel@...sung.com>, <gost.dev@...sung.com>
Subject: RE: [PATCH v4 2/4] net: stmmac: dwc-qos: Add FSD EQoS support



> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: 31 July 2024 01:44
> To: Swathi K S <swathi.ks@...sung.com>
> Cc: krzk@...nel.org; robh@...nel.org; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> conor+dt@...nel.org; richardcochran@...il.com;
> mcoquelin.stm32@...il.com; alim.akhtar@...sung.com; linux-
> fsd@...la.com; netdev@...r.kernel.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-stm32@...md-mailman.stormreply.com; linux-
> arm-kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org;
> alexandre.torgue@...s.st.com; peppe.cavallaro@...com;
> joabreu@...opsys.com; rcsekar@...sung.com; ssiddha@...la.com;
> jayati.sahu@...sung.com; pankaj.dubey@...sung.com;
> ravi.patel@...sung.com; gost.dev@...sung.com
> Subject: Re: [PATCH v4 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
> 
> > +static int dwc_eqos_rxmux_setup(void *priv, bool external) {
> > +	int i = 0;
> > +	struct fsd_eqos_plat_data *plat = priv;
> > +	struct clk *rx1 = NULL;
> > +	struct clk *rx2 = NULL;
> > +	struct clk *rx3 = NULL;
> 
> Reverse Christmas tree please.

Thanks for review.
We will take care in next patch version after waiting for other review
comments.

> 
> > @@ -264,6 +264,7 @@ struct plat_stmmacenet_data {
> >  	void (*ptp_clk_freq_config)(struct stmmac_priv *priv);
> >  	int (*init)(struct platform_device *pdev, void *priv);
> >  	void (*exit)(struct platform_device *pdev, void *priv);
> > +	int (*rxmux_setup)(void *priv, bool external);
> >  	struct mac_device_info *(*setup)(void *priv);
> >  	int (*clks_config)(void *priv, bool enabled);
> >  	int (*crosststamp)(ktime_t *device, struct system_counterval_t
> > *system,
> 
> It would be good if one of the stmmas Maintainers looked at this. There
are
> already a lot of function pointers here, we should not be added another
one if
> one of the exiting ones could be used.
> 
>     Andrew
> 
> ---
> pw-bot: cr