netdev - Re: [PATCH can-next 11/21] can: rockchip_canfd: add functions to check if CAN-FD frames are equal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240731-burrowing-lionfish-of-grandeur-e45e30-mkl@pengutronix.de>
Date: Wed, 31 Jul 2024 10:02:00 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Simon Horman <horms@...nel.org>
Cc: kernel@...gutronix.de, Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Elaine Zhang <zhangqing@...k-chips.com>, David Jander <david.jander@...tonic.nl>, 
	linux-can@...r.kernel.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH can-next 11/21] can: rockchip_canfd: add functions to
 check if CAN-FD frames are equal

On 30.07.2024 17:37:30, Simon Horman wrote:
> On Mon, Jul 29, 2024 at 03:05:42PM +0200, Marc Kleine-Budde wrote:
> > Add a pair new functions to check if 2 struct canfd_frame are equal.
> > The 1st checks if the header of the CAN frames are equal, the 2nd
> > checks if the data portion are equal:
> > 
> > - rkcanfd_can_frame_header_equal()
> > - rkcanfd_can_frame_data_equal()
> > 
> > This functionality is needed in the next patch.
> 
> nit: I would squash this into the next patch as
>      rkcanfd_can_frame_header_equal() is defined but
>      unused in this patch, which is flagged by
>      allmodconfig W=1 builds.

Makes sense, done.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)