netdev - RE: [Intel-wired-lan] [PATCH iwl-next, v1 2/3] igc: Add default Rx queue configuration via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR11MB5830F3526D9A3213D736D045D8B22@PH0PR11MB5830.namprd11.prod.outlook.com>
Date: Thu, 1 Aug 2024 07:56:47 +0000
From: "Song, Yoong Siang" <yoong.siang.song@...el.com>
To: Marcin Szycik <marcin.szycik@...ux.intel.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "David S . Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, "Alexei
 Starovoitov" <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
	"Jesper Dangaard Brouer" <hawk@...nel.org>, John Fastabend
	<john.fastabend@...il.com>, "Gomes, Vinicius" <vinicius.gomes@...el.com>,
	Jonathan Corbet <corbet@....net>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Shinas Rasheed <srasheed@...vell.com>, "Tian,
 Kevin" <kevin.tian@...el.com>, Brett Creeley <brett.creeley@....com>, "Blanco
 Alcaine, Hector" <hector.blanco.alcaine@...el.com>, "Hay, Joshua A"
	<joshua.a.hay@...el.com>, "Neftin, Sasha" <sasha.neftin@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "bpf@...r.kernel.org"
	<bpf@...r.kernel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next, v1 2/3] igc: Add default Rx
 queue configuration via sysfs

On Tuesday, July 30, 2024 9:20 PM, Marcin Szycik <marcin.szycik@...ux.intel.com> wrote:
>On 30.07.2024 03:23, Song Yoong Siang wrote:
>> From: Blanco Alcaine Hector <hector.blanco.alcaine@...el.com>
>>
>> This commit introduces the support to configure default Rx queue during
>
>Use imperative mood.
>

Hi Marcin Szycik,
Thanks for your review comments.
Sure, I will use imperative mood in the commit msg.
[...]

>> +/* MRQC register bit definitions */
>> +#define IGC_MRQC_ENABLE_MQ		0x00000000
>
>Just 0.
>

Noted.
[...]

>> +	if (queue > adapter->rss_queues - 1) {
>
>if (queue >= adapter->rss_queues)
>

Noted.
[...]

>> +static ssize_t default_rx_queue_show(struct device *dev,
>> +				     struct device_attribute *attr,
>> +				     char *buf)
>
>Why no igc_ prefix (and function doc)?
>

Sure. Will add igc prefix in the function name.
[...]

>> +static ssize_t default_rx_queue_store(struct device *dev,
>> +				      struct device_attribute *attr,
>> +				      const char *buf, size_t count)
>
>Ditto
>

Noted.
[...]

>> +	err = igc_set_default_rx_queue(adapter, default_rx_queue);
>> +	if (err < 0)
>> +		return -EINVAL;
>
>Why discard return error here?
>

Will use "return err" in v2 submission.
[...]

>
>Thanks,
>Marcin

Thanks & Regards
Siang