netdev - Re: [PATCH net-next v2 4/4] bnxt_en: only set dev->queue_mgmt_ops if BNXT_SUPPORTS_NTUPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3cd7c1c5-3e84-44f0-8552-ea5d95aa6b7c@davidwei.uk>
Date: Thu, 1 Aug 2024 09:59:49 +0100
From: David Wei <dw@...idwei.uk>
To: Michael Chan <michael.chan@...adcom.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH net-next v2 4/4] bnxt_en: only set dev->queue_mgmt_ops if
 BNXT_SUPPORTS_NTUPLE_VNIC

On 2024-08-01 02:33, Michael Chan wrote:
> On Wed, Jul 31, 2024 at 6:15 AM David Wei <dw@...idwei.uk> wrote:
>>
>> The queue API calls bnxt_hwrm_vnic_update() to stop/start the flow of
>> packets. It can only be called if BNXT_SUPPORTS_NTUPLE_VNIC(), so key
>> support for it by only setting queue_mgmt_ops if this is true.
>>
>> Signed-off-by: David Wei <dw@...idwei.uk>
>> ---
>>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
>> index ce60c9322fe6..2801ae94d87b 100644
>> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
>> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
>> @@ -15713,7 +15713,6 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>>         dev->stat_ops = &bnxt_stat_ops;
>>         dev->watchdog_timeo = BNXT_TX_TIMEOUT;
>>         dev->ethtool_ops = &bnxt_ethtool_ops;
>> -       dev->queue_mgmt_ops = &bnxt_queue_mgmt_ops;
>>         pci_set_drvdata(pdev, dev);
>>
>>         rc = bnxt_alloc_hwrm_resources(bp);
>> @@ -15892,8 +15891,10 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>>
>>         INIT_LIST_HEAD(&bp->usr_fltr_list);
>>
>> -       if (BNXT_SUPPORTS_NTUPLE_VNIC(bp))
>> +       if (BNXT_SUPPORTS_NTUPLE_VNIC(bp)) {
> 
> Thanks for the patch.  We found out during internal testing that an
> additional FW fix is required to make the ring restart 100% reliable
> with traffic.  FW needs to add one more step to flush the RX pipeline
> during HWRM_VNIC_UPDATE.  Once we determine which FW versions will
> have the fix, we can add the conditional check here to make this patch
> more complete.  I think we just need about a week to determine that.
> Please hold off on this patchset.  Thanks.

Got it, no problem. Let me know the FW version and I'll gate the ops
behind it. Thanks.