netdev - Re: [PATCH net-next] ipv6: eliminate ndisc_ops_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62ae3755-f51d-4953-928f-ff2faf7cea72@redhat.com>
Date: Thu, 1 Aug 2024 15:54:42 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Maciej Żenczykowski <maze@...gle.com>,
 Maciej Żenczykowski <zenczykowski@...il.com>
Cc: Linux Network Development Mailing List <netdev@...r.kernel.org>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 David Ahern <dsahern@...nel.org>,
 YOSHIFUJI Hideaki / 吉藤英明
 <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH net-next] ipv6: eliminate ndisc_ops_is_useropt()

On 7/30/24 02:30, Maciej Żenczykowski wrote:
> as it doesn't seem to offer anything of value.
> 
> There's only 1 trivial user:
>    int lowpan_ndisc_is_useropt(u8 nd_opt_type) {
>      return nd_opt_type == ND_OPT_6CO;
>    }
> 
> but there's no harm to always treating that as
> a useropt...

AFAICS there will be an user-visible difference, as the user-space could 
start receiving "unexpected" notification for such opt even when the 
kernel is built with CONFIG_6LOWPAN=n.

The user-space should ignore unknown/unexpected notification,so it 
should be safe, but I'm a bit unsettled by the many 'should' ;)

Cheers,

Paolo