netdev - Re: [PATCH net 1/1] net: usb: qmi_wwan: fix memory leak for not ip packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ttg4gvnz.fsf@miraculix.mork.no>
Date: Thu, 01 Aug 2024 16:33:20 +0200
From: Bjørn Mork <bjorn@...k.no>
To: Daniele Palmas <dnlplm@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
        netdev@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH net 1/1] net: usb: qmi_wwan: fix memory leak for not ip
 packets

Daniele Palmas <dnlplm@...il.com> writes:

> Free the unused skb when not ip packets arrive.
>
> Fixes: c6adf77953bc ("net: usb: qmi_wwan: add qmap mux protocol support")
> Signed-off-by: Daniele Palmas <dnlplm@...il.com>
> ---
>  drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 386d62769ded..cfda32047cff 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -201,6 +201,7 @@ static int qmimux_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
>  			break;
>  		default:
>  			/* not ip - do not know what to do */
> +			kfree_skb(skbn);
>  			goto skip;
>  		}


Makes sense.

Acked-by: Bjørn Mork <bjorn@...k.no>