netdev - Re: [net-next,v4] net: phy: phy_device: fix PHY WOL enabled, PM failed to suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240801085123.6757d4c3@kernel.org>
Date: Thu, 1 Aug 2024 08:51:23 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Youwan Wang <youwan@...china.com>
Cc: linux@...linux.org.uk, andrew@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, hkallweit1@...il.com, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, pabeni@...hat.com, Russell King
 <rmk+kernel@...linux.org.uk>, Wojciech Drewek <wojciech.drewek@...el.com>
Subject: Re: [net-next,v4] net: phy: phy_device: fix PHY WOL enabled, PM
 failed to suspend

On Wed, 31 Jul 2024 17:15:37 +0800 Youwan Wang wrote:
> +	/* If the PHY on the mido bus is not attached but has WOL enabled
> +	 * we cannot suspend the PHY.
> +	 */
> +	if (!netdev && phy_drv_wol_enabled(phydev))
> +		return false;

Not sure why you stopped setting phydev->wol_enabled between v2 and v3
but let's hear from phy maintainers..