netdev - Re: [PATCH net-next] ethtool: Don't check for NULL info in prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240731182043.51286ac6@kernel.org>
Date: Wed, 31 Jul 2024 18:20:43 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Maxime Chevallier
 <maxime.chevallier@...tlin.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ethtool: Don't check for NULL info in
 prepare_data callbacks

On Wed, 31 Jul 2024 10:15:28 +0100 Simon Horman wrote:
> Since commit f946270d05c2 ("ethtool: netlink: always pass genl_info to
> .prepare_data") the info argument of prepare_data callbacks is never
> NULL. Remove checks present in callback implementations.
> 
> Link: https://lore.kernel.org/netdev/20240703121237.3f8b9125@kernel.org/
> Signed-off-by: Simon Horman <horms@...nel.org>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>