[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240801172631.GI4209@unreal>
Date: Thu, 1 Aug 2024 20:26:31 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Jason Gunthorpe <jgg@...dia.com>
Cc: Jonathan Corbet <corbet@....net>, Itay Avraham <itayavr@...dia.com>,
Jakub Kicinski <kuba@...nel.org>, linux-doc@...r.kernel.org,
linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
Paolo Abeni <pabeni@...hat.com>, Saeed Mahameed <saeedm@...dia.com>,
Tariq Toukan <tariqt@...dia.com>,
Andy Gospodarek <andrew.gospodarek@...adcom.com>,
Aron Silverton <aron.silverton@...cle.com>,
Dan Williams <dan.j.williams@...el.com>,
David Ahern <dsahern@...nel.org>,
Christoph Hellwig <hch@...radead.org>, Jiri Pirko <jiri@...dia.com>,
Leonid Bloch <lbloch@...dia.com>, linux-cxl@...r.kernel.org,
patches@...ts.linux.dev
Subject: Re: [PATCH v2 5/8] fwctl: FWCTL_RPC to execute a Remote Procedure
Call to device firmware
On Thu, Aug 01, 2024 at 09:58:29AM -0300, Jason Gunthorpe wrote:
> On Tue, Jul 30, 2024 at 11:00:38AM +0300, Leon Romanovsky wrote:
> > > +
> > > + void *inbuf __free(kvfree) =
> > > + kvzalloc(cmd->in_len, GFP_KERNEL | GFP_KERNEL_ACCOUNT);
> >
> >
> > <...>
> >
> > > + out_len = cmd->out_len;
> > > + void *outbuf __free(kvfree_errptr) = fwctl->ops->fw_rpc(
> > > + ucmd->uctx, cmd->scope, inbuf, cmd->in_len, &out_len);
> >
> > I was under impression that declaration of variables in C should be at the beginning
> > of block. Was it changed for the kernel?
>
> Yes, the compiler check blocking variables in the body was disabled to
> allow cleanup.h
>
> Jonathan said this is the agreed coding style to use for this
I'm said to hear that.
Thanks
>
> Jason
Powered by blists - more mailing lists