netdev - Re: [PATCH net-next v2 1/6] rust: sizes: add commonly used constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240801.102146.301991981941433687.fujita.tomonori@gmail.com>
Date: Thu, 01 Aug 2024 10:21:46 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: aliceryhl@...gle.com
Cc: andrew@...n.ch, fujita.tomonori@...il.com, netdev@...r.kernel.org,
 rust-for-linux@...r.kernel.org, tmgross@...ch.edu,
 miguel.ojeda.sandonis@...il.com, benno.lossin@...ton.me
Subject: Re: [PATCH net-next v2 1/6] rust: sizes: add commonly used
 constants

On Wed, 31 Jul 2024 14:30:23 +0200
Alice Ryhl <aliceryhl@...gle.com> wrote:

>> > +//! Commonly used sizes.
>> > +//!
>> > +//! C headers: [`include/linux/sizes.h`](srctree/include/linux/sizes.h).
>> > +
>> > +/// 0x00000400
>> > +pub const SZ_1K: usize = bindings::SZ_1K as usize;
>>
>> 1K is 1K, independent of it being C 1K or Rust 1K. In this case, does
>> it makes sense to actually use the C header? I don't know? But the
>> Rust people seems to think this is O.K.
> 
> Shrug. I don't think it really matters.
> 
> If using the C header required adding constants in
> rust/bindings/bindings_helper.h to actually make the constants usable
> from Rust, then I would say we should just set the constants from the
> Rust side. But in this case using the C header just works so I don't
> think it's an issue.

Either is fine by me. I'll keep the current version if nobody has
strong preference.

Thanks for the quick review!