netdev - Re: [PATCH v3 06/12] netlink: spec: add shaper introspection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2r0b7np9w.fsf@gmail.com>
Date: Fri, 02 Aug 2024 12:21:47 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org,  Jakub Kicinski <kuba@...nel.org>,  Jiri Pirko
 <jiri@...nulli.us>,  Madhu Chittim <madhu.chittim@...el.com>,  Sridhar
 Samudrala <sridhar.samudrala@...el.com>,  Simon Horman <horms@...nel.org>,
  John Fastabend <john.fastabend@...il.com>,  Sunil Kovvuri Goutham
 <sgoutham@...vell.com>,  Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH v3 06/12] netlink: spec: add shaper introspection support

Paolo Abeni <pabeni@...hat.com> writes:
> +      -
> +        name: support-nesting
> +        type: flag
> +        doc: |
> +          the device supports nesting shaper belonging to this scope

Nit: capitalize all the doc strings for consistency.

> +          below 'detached' scoped shapers. Only 'queue' and 'detached'
> +          scope and flag 'support-nesting'.

'and flag' looks like a typo. Do you mean 'can have flag'?

> +    -
> +      name: cap-get
> +      doc: |
> +        Get / Dump the shaper capabilities supported by the given device
> +      attribute-set: capabilities
> +
> +      do:
> +        request:
> +          attributes:
> +            - ifindex
> +            - scope
> +        reply:
> +          attributes: &cap-attrs
> +            - support-metric-bps
> +            - support-metric-pps
> +            - support-nesting
> +            - support-bw-min
> +            - support-bw-max
> +            - support-burst
> +            - support-priority
> +            - support-weight
> +
> +      dump:
> +        request:
> +          attributes:
> +            - ifindex
> +        reply:
> +          attributes: *cap-attrs

scope is missing from the dump reply