netdev - Re: [PATCH net-next 03/12] eth: mlx5: allow disabling queues when RSS contexts exist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqzCsvm8DW6PeKDQ@LQ3V64L9R2>
Date: Fri, 2 Aug 2024 12:27:46 +0100
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, dxu@...uu.xyz, ecree.xilinx@...il.com,
	przemyslaw.kitszel@...el.com, donald.hunter@...il.com,
	gal.pressman@...ux.dev, tariqt@...dia.com,
	willemdebruijn.kernel@...il.com, saeedm@...dia.com, leon@...nel.org,
	linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next 03/12] eth: mlx5: allow disabling queues when
 RSS contexts exist

On Thu, Aug 01, 2024 at 05:17:52PM -0700, Jakub Kicinski wrote:
> Since commit 24ac7e544081 ("ethtool: use the rss context XArray
> in ring deactivation safety-check") core will prevent queues from
> being disabled while being used by additional RSS contexts.
> The safety check is no longer necessary, and core will do a more
> accurate job of only rejecting changes which can actually break
> things.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: saeedm@...dia.com
> CC: tariqt@...dia.com
> CC: leon@...nel.org
> CC: linux-rdma@...r.kernel.org
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
> index 36845872ae94..0b941482db30 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
> @@ -445,7 +445,6 @@ int mlx5e_ethtool_set_channels(struct mlx5e_priv *priv,
>  	unsigned int count = ch->combined_count;
>  	struct mlx5e_params new_params;
>  	bool arfs_enabled;
> -	int rss_cnt;
>  	bool opened;
>  	int err = 0;
>  
> @@ -499,17 +498,6 @@ int mlx5e_ethtool_set_channels(struct mlx5e_priv *priv,
>  		goto out;
>  	}
>  
> -	/* Don't allow changing the number of channels if non-default RSS contexts exist,
> -	 * the kernel doesn't protect against set_channels operations that break them.
> -	 */
> -	rss_cnt = mlx5e_rx_res_rss_cnt(priv->rx_res) - 1;
> -	if (rss_cnt) {
> -		err = -EINVAL;
> -		netdev_err(priv->netdev, "%s: Non-default RSS contexts exist (%d), cannot change the number of channels\n",
> -			   __func__, rss_cnt);
> -		goto out;
> -	}
> -
>  	/* Don't allow changing the number of channels if MQPRIO mode channel offload is active,
>  	 * because it defines a partition over the channels queues.
>  	 */
> -- 
> 2.45.2

Reviewed-by: Joe Damato <jdamato@...tly.com>