netdev - Re: [PATCH net-next 06/12] ethtool: rss: don't report key if device doesn't support it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqzJ6tLil3vwvfgh@LQ3V64L9R2>
Date: Fri, 2 Aug 2024 12:58:34 +0100
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, dxu@...uu.xyz, ecree.xilinx@...il.com,
	przemyslaw.kitszel@...el.com, donald.hunter@...il.com,
	gal.pressman@...ux.dev, tariqt@...dia.com,
	willemdebruijn.kernel@...il.com
Subject: Re: [PATCH net-next 06/12] ethtool: rss: don't report key if device
 doesn't support it

On Thu, Aug 01, 2024 at 05:17:55PM -0700, Jakub Kicinski wrote:
> marvell/otx2 and mvpp2 do not support setting different
> keys for different RSS contexts. Contexts have separate
> indirection tables but key is shared with all other contexts.
> This is likely fine, indirection table is the most important
> piece.
> 
> Don't report the key-related parameters from such drivers.
> This prevents driver-errors, e.g. otx2 always writes
> the main key, even when user asks to change per-context key.
> The second reason is that without this change tracking
> the keys by the core gets complicated. Even if the driver
> correctly reject setting key with rss_context != 0,
> change of the main key would have to be reflected in
> the XArray for all additional contexts.
> 
> Since the additional contexts don't have their own keys
> not including the attributes (in Netlink speak) seems
> intuitive. ethtool CLI seems to deal with it just fine.

FWIW: I took a look at the ethtool source and I agree, but didn't
test it.

> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  1 +
>  drivers/net/ethernet/intel/ice/ice_ethtool.c  |  1 +
>  .../ethernet/mellanox/mlx5/core/en_ethtool.c  |  1 +
>  drivers/net/ethernet/sfc/ef100_ethtool.c      |  1 +
>  drivers/net/ethernet/sfc/ethtool.c            |  1 +
>  drivers/net/ethernet/sfc/siena/ethtool.c      |  1 +
>  include/linux/ethtool.h                       |  3 +++
>  net/ethtool/ioctl.c                           | 25 ++++++++++++++++---
>  net/ethtool/rss.c                             | 21 +++++++++++-----
>  9 files changed, 45 insertions(+), 10 deletions(-)

Reviewed-by: Joe Damato <jdamato@...tly.com>