netdev - Re: [PATCH net-next v2] net: mctp: Consistent peer address handling in ioctl tag allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fde081adb2352e613ae33536363f284f1b46f32.camel@codeconstruct.com.au>
Date: Fri, 02 Aug 2024 08:21:46 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Jakub Kicinski <kuba@...nel.org>, Matt Johnston
 <matt@...econstruct.com.au>
Cc: John Wang <wangzq.jn@...il.com>, "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: mctp: Consistent peer address handling
 in ioctl tag allocation

Hi Jakub and John,

> On Tue, 30 Jul 2024 16:46:35 +0800 John Wang wrote:
> > When executing ioctl to allocate tags, if the peer address is 0,
> > mctp_alloc_local_tag now replaces it with 0xff. However, during tag
> > dropping, this replacement is not performed, potentially causing
> > the key
> > not to be dropped as expected.
> > 
> > Signed-off-by: John Wang <wangzhiqiang02@...system.com>
> 
> Looks sane. Jeremy? Matt?

All looks good to me!

Reviewed-by: Jeremy Kerr <jk@...econstruct.com.au>

(John had already discussed the change with us, so no surprises on my
side)

> In netdev we try to review patches within 24-48 hours.
> You have willingly boarded this crazy train.. :)

Yeah we bought express tickets to netdev town! I just saw that there
were nipa warnings on patchwork, so was waiting on a v3. If it's okay
as-is, I'm happy for a merge.

Cheers,

Jeremy