netdev - Re: [PATCH net] eth: fbnic: select devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240802145038.GE2504122@kernel.org>
Date: Fri, 2 Aug 2024 15:50:38 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, kernel test robot <lkp@...el.com>,
	alexanderduyck@...com
Subject: Re: [PATCH net] eth: fbnic: select devlink

On Thu, Aug 01, 2024 at 06:59:24PM -0700, Jakub Kicinski wrote:
> Build bot reports undefined references to devlink functions
> in fbnic.ko.
> 
> Fixes: 1a9d48892ea5 ("eth: fbnic: Allocate core device specific structures and devlink interface")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202408011219.hiPmwwAs-lkp@intel.com/
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Thanks, I agree this is needed.

Reviewed-by: Simon Horman <horms@...nel.org>
Tested-by: Simon Horman <horms@...nel.org>

But while exercising this I noticed that PAGE_POOL is also needed,
which I locally resolved by adding:

	select PAGE_POOL

I can provide a follow-up patch after this one is merged.
Or perhaps you can address this in a v2?
I have no preference either way.