netdev - Re: [PATCH net] gve: Fix use of netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+f9V1NeVd-t2y-MbFi-NhSpCS=sm5Mx9pRJG=u86UkRJx5cBQ@mail.gmail.com>
Date: Fri, 2 Aug 2024 09:24:53 -0700
From: Praveen Kaligineedi <pkaligineedi@...gle.com>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, willemb@...gle.com, jeroendb@...gle.com, 
	shailend@...gle.com, hramamurthy@...gle.com, jfraker@...gle.com
Subject: Re: [PATCH net] gve: Fix use of netif_carrier_ok()

> > -     if (netif_carrier_ok(priv->dev)) {
> > +     if (netif_running(priv->dev)) {
> >               err = gve_adjust_config(priv, &tx_alloc_cfg, &rx_alloc_cfg);
> >               return err;
> >       }
>
> Hi Praveen,
>
> Not for this patch, but I am curious to know if this check is needed at
> all, because gve_adjust_queues only seems to be called from
> gve_set_channels if netif_running() (previously netif_carrier_ok()) is true
>
> ...
>
Thanks Simon. I am aware of it. I am planning to send a follow-up patch
to net-next to remove the redundant check.