netdev - Re: [PATCH] tg3: Add param `short_preamble` to enable MDIO traffic to external PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLimBsxB=jsjbS+GTd+0yMtFc4Qh55Y_DzY9SFOryYbwLFA@mail.gmail.com>
Date: Fri, 2 Aug 2024 14:25:14 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: Pavan Chebbi <pavan.chebbi@...adcom.com>, Michael Chan <mchan@...adcom.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Roy Lee <roy_lee@...ton.com>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Saikrishna Arcot <sarcot@...rosoft.com>, Guohan Lu <lguohan@...il.com>
Subject: Re: [PATCH] tg3: Add param `short_preamble` to enable MDIO traffic to
 external PHYs

On Fri, Aug 2, 2024 at 1:55 PM Paul Menzel <pmenzel@...gen.mpg.de> wrote:
>
> >> +static int short_preamble = 0;
> >> +module_param(short_preamble, int, 0);
> >> +MODULE_PARM_DESC(short_preamble, "Enable short preamble.");
> >> +
> >
> > Module parameters are generally not accepted.  If this is something
> > other devices can potentially use, it's better to use a more common
> > interface.
>
> I saw the patch in the SONiC repository and took a shot at upstreaming
> it. `tg.h` defines the macro:
>
>      #define  MAC_MI_MODE_SHORT_PREAMBLE  0x00000002
>
> Any idea how this should be used? Can it be enabled unconditionally? I
> do not even have the datasheet.
>

Here's the programmer's reference:

https://docs.broadcom.com/doc/571X-5720-PG1XX

But there is not much additional information about the SHORT_PREAMBLE
bit.  I will need to ask internally about this bit.  Thanks.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)