netdev - Re: [PATCH net 0/7] mptcp: fix endpoints with 'signal' and 'subflow' flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172256283237.5499.17809617500066693516.git-patchwork-notify@kernel.org>
Date: Fri, 02 Aug 2024 01:40:32 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Matthieu Baerts (NGI0) <matttbe@...nel.org>
Cc: mptcp@...ts.linux.dev, martineau@...nel.org, geliang@...nel.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 shuah@...nel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net 0/7] mptcp: fix endpoints with 'signal' and 'subflow'
 flags

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 31 Jul 2024 13:05:52 +0200 you wrote:
> When looking at improving the user experience around the MPTCP endpoints
> setup, I noticed that setting an endpoint with both the 'signal' and the
> 'subflow' flags -- as it has been done in the past by users according to
> bug reports we got -- was resulting on only announcing the endpoint, but
> not using it to create subflows: the 'subflow' flag was then ignored.
> 
> My initial thought was to modify IPRoute2 to warn the user when the two
> flags were set, but it doesn't sound normal to ignore one of them. I
> then looked at modifying the kernel not to allow having the two flags
> set, but when discussing about that with Mat, we thought it was maybe
> not ideal to do that, as there might be use-cases, we might break some
> configs. Then I saw it was working before v5.17. So instead, I fixed the
> support on the kernel side (patch 5) using Paolo's suggestion. This also
> includes a fix on the options side (patch 1: for v5.11+), an explicit
> deny of some options combinations (patch 2: for v5.18+), and some
> refactoring (patches 3 and 4) to ease the inclusion of the patch 5.
> 
> [...]

Here is the summary with links:
  - [net,1/7] mptcp: fully established after ADD_ADDR echo on MPJ
    https://git.kernel.org/netdev/net/c/d67c5649c154
  - [net,2/7] mptcp: pm: deny endp with signal + subflow + port
    https://git.kernel.org/netdev/net/c/8af1f11865f2
  - [net,3/7] mptcp: pm: reduce indentation blocks
    https://git.kernel.org/netdev/net/c/c95eb32ced82
  - [net,4/7] mptcp: pm: don't try to create sf if alloc failed
    https://git.kernel.org/netdev/net/c/cd7c957f936f
  - [net,5/7] mptcp: pm: do not ignore 'subflow' if 'signal' flag is also set
    https://git.kernel.org/netdev/net/c/85df533a787b
  - [net,6/7] selftests: mptcp: join: ability to invert ADD_ADDR check
    https://git.kernel.org/netdev/net/c/bec1f3b119eb
  - [net,7/7] selftests: mptcp: join: test both signal & subflow
    https://git.kernel.org/netdev/net/c/4d2868b5d191

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html