netdev - Re: [PATCH net v4 1/2] virtio-net: check feature before configuring the vq coalescing command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEtiLsg6NKNB3TmwchxB-MbBYBnnsEJh1Cq3gHh1K7djbQ@mail.gmail.com>
Date: Fri, 2 Aug 2024 10:55:03 +0800
From: Jason Wang <jasowang@...hat.com>
To: Heng Qi <hengqi@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, "Michael S. Tsirkin" <mst@...hat.com>, virtualization@...ts.linux.dev, 
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, 
	"David S. Miller" <davem@...emloft.net>, Eugenio Pérez <eperezma@...hat.com>, 
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Subject: Re: [PATCH net v4 1/2] virtio-net: check feature before configuring
 the vq coalescing command

On Thu, Aug 1, 2024 at 9:23 PM Heng Qi <hengqi@...ux.alibaba.com> wrote:
>
> Virtio spec says:
>
>         The driver MUST have negotiated the VIRTIO_NET_F_VQ_NOTF_COAL
>         feature when issuing commands VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET
>         and VIRTIO_NET_CTRL_NOTF_COAL_VQ_GET.
>
> So we add the feature negotiation check to
> virtnet_send_{r,t}x_ctrl_coal_vq_cmd as a basis for the next bugfix patch.
>
> Suggested-by: Michael S. Tsirkin <mst@...hat.com>
> Signed-off-by: Heng Qi <hengqi@...ux.alibaba.com>
> ---

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks