netdev - Re: [PATCH net-next] net: remove IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqyDrsiheWwDebsI@nanopsycho.orion>
Date: Fri, 2 Aug 2024 08:58:54 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com
Subject: Re: [PATCH net-next] net: remove IFF_* re-definition

Thu, Aug 01, 2024 at 06:34:01PM CEST, kuba@...nel.org wrote:
>We re-define values of enum netdev_priv_flags as preprocessor
>macros with the same name. I guess this was done to avoid breaking
>out of tree modules which may use #ifdef X for kernel compatibility?
>Commit 7aa98047df95 ("net: move net_device priv_flags out from UAPI")
>which added the enum doesn't say. In any case, the flags with defines
>are quite old now, and defines for new flags don't get added.
>OOT drivers have to resort to code greps for compat detection, anyway.
>Let's delete these defines, save LoC, help LXR link to the right place.
>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>