netdev - RE: [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration ethtool_cmis_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM6PR12MB45166954774CA935EA0777E5D8BD2@DM6PR12MB4516.namprd12.prod.outlook.com>
Date: Sun, 4 Aug 2024 08:08:20 +0000
From: Danielle Ratson <danieller@...dia.com>
To: Yue Haibing <yuehaibing@...wei.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration
 ethtool_cmis_page_fini()

> From: Yue Haibing <yuehaibing@...wei.com>
> Sent: Saturday, 3 August 2024 14:22
> To: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; Danielle Ratson <danieller@...dia.com>;
> yuehaibing@...wei.com
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH net-next] ethtool: cmis_cdb: Remove unused declaration
> ethtool_cmis_page_fini()
> 
> ethtool_cmis_page_fini() is declared but never implemented.
> 
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> ---
>  net/ethtool/cmis.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/ethtool/cmis.h b/net/ethtool/cmis.h index
> e71cc3e1b7eb..3e7c293af78c 100644
> --- a/net/ethtool/cmis.h
> +++ b/net/ethtool/cmis.h
> @@ -108,7 +108,6 @@ void ethtool_cmis_cdb_check_completion_flag(u8
> cmis_rev, u8 *flags);
> 
>  void ethtool_cmis_page_init(struct ethtool_module_eeprom *page_data,
>  			    u8 page, u32 offset, u32 length); -void
> ethtool_cmis_page_fini(struct ethtool_module_eeprom *page_data);
> 
>  struct ethtool_cmis_cdb *
>  ethtool_cmis_cdb_init(struct net_device *dev,
> --
> 2.34.1
> 

Reviewed-by: Danielle Ratson <danieller@...dia.com>

Thanks!