netdev - Re: [PATCH v2 iproute2] libnetlink.h: Include <endian.h> explicitly for musl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240804095811.04600a4d@hermes.local>
Date: Sun, 4 Aug 2024 09:58:11 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: "Andreas K. Hüttel" <dilfridge@...too.org>
Cc: netdev@...r.kernel.org, base-system@...too.org
Subject: Re: [PATCH v2 iproute2] libnetlink.h: Include <endian.h> explicitly
 for musl

On Sun,  4 Aug 2024 18:03:23 +0200
Andreas K. Hüttel <dilfridge@...too.org> wrote:

> The code added in "f_flower: implement pfcp opts" uses h2be64,
> defined in endian.h. While this is pulled in around some corners
> for glibc (see below), that's not the case for musl and an
> explicit include is required there.
> 
> . /usr/include/libmnl/libmnl.h
> .. /usr/include/sys/socket.h
> ... /usr/include/bits/socket.h
> .... /usr/include/sys/types.h
> ..... /usr/include/endian.h
> 
> Fixes: 976dca372 ("f_flower: implement pfcp opts")
> Bug: https://bugs.gentoo.org/936234
> Signed-off-by: Andreas K. Hüttel <dilfridge@...too.org>

Other parts of flower code use htonll().
It would have been better to be consistent and not use h2be64() at all.