netdev - Re: [PATCH net-next v2 04/12] ethtool: make ethtool_ops::cap_rss_ctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1f4eff4-415d-4d0d-95d7-c7c1c813cf2a@nvidia.com>
Date: Sun, 4 Aug 2024 09:46:28 +0300
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 dxu@...uu.xyz, ecree.xilinx@...il.com, przemyslaw.kitszel@...el.com,
 donald.hunter@...il.com, tariqt@...dia.com, willemdebruijn.kernel@...il.com,
 jdamato@...tly.com
Subject: Re: [PATCH net-next v2 04/12] ethtool: make
 ethtool_ops::cap_rss_ctx_supported optional

On 03/08/2024 7:26, Jakub Kicinski wrote:
> cap_rss_ctx_supported was created because the API for creating
> and configuring additional contexts is mux'ed with the normal
> RSS API. Presence of ops does not imply driver can actually
> support rss_context != 0 (in fact drivers mostly ignore that
> field). cap_rss_ctx_supported lets core check that the driver
> is context-aware before calling it.
> 
> Now that we have .create_rxfh_context, there is no such
> ambiguity. We can depend on presence of the op.
> Make setting the bit optional.

Reviewed-by: Gal Pressman <gal@...dia.com>