netdev - Re: [PATCH net-next v2 02/12] eth: mvpp2: implement new RSS context API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1683568d-41b5-ffc8-2b08-ac734fe993a7@gmail.com>
Date: Mon, 5 Aug 2024 12:25:28 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 dxu@...uu.xyz, przemyslaw.kitszel@...el.com, donald.hunter@...il.com,
 gal.pressman@...ux.dev, tariqt@...dia.com, willemdebruijn.kernel@...il.com,
 jdamato@...tly.com, marcin.s.wojtas@...il.com, linux@...linux.org.uk
Subject: Re: [PATCH net-next v2 02/12] eth: mvpp2: implement new RSS context
 API

On 03/08/2024 05:26, Jakub Kicinski wrote:
> Implement the separate create/modify/delete ops for RSS.
> 
> No problems with IDs - even tho RSS tables are per device
> the driver already seems to allocate IDs linearly per port.
> There's a translation table from per-port context ID
> to device context ID.
> 
> mvpp2 doesn't have a key for the hash, it defaults to
> an empty/previous indir table.

Given that, should this be after patch #6?  So as to make it
 obviously correct not to populate ethtool_rxfh_context_key(ctx)
 with the default context's key.

> @@ -5750,6 +5792,7 @@ static const struct net_device_ops mvpp2_netdev_ops = {
>  
>  static const struct ethtool_ops mvpp2_eth_tool_ops = {
>  	.cap_rss_ctx_supported	= true,
> +	.rxfh_max_context_id	= MVPP22_N_RSS_TABLES,

Max ID is inclusive, not exclusive, so I think this should be
 MVPP22_N_RSS_TABLES - 1?