netdev - Re: [PATCH] net: fec: Remove duplicated code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b13b44e-54b2-4b83-9649-18f36ad3bf8b@prolan.hu>
Date: Mon, 5 Aug 2024 17:36:49 +0200
From: Csókás Bence <csokas.bence@...lan.hu>
To: Frank Li <Frank.li@....com>
CC: <imx@...ts.linux.dev>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Wei Fang <wei.fang@....com>, Shenwei Wang
	<shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Richard Cochran
	<richardcochran@...il.com>
Subject: Re: [PATCH] net: fec: Remove duplicated code



On 8/5/24 17:31, Frank Li wrote:
> On Mon, Aug 05, 2024 at 04:47:55PM +0200, Csókás, Bence wrote:
>> -	ptp_hc = readl(fep->hwp + FEC_ATIME);
>> +	ptp_hc = fep->cc.read(&fep->cc);
> 
> why not call fec_ptp_read() directly?
> 
> Frank

It is defined later in the file. Using the struct cyclecounter was the 
solution for this we settled on in 61d5e2a251fb ("fec: Fix timer capture 
timing in `fec_ptp_enable_pps()`") as well.

Bence