netdev - Re: [PATCH] net: dsa: bcm_sf2: Fix a possible memory leak in bcm_sf2_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240805163228.16956875@kernel.org>
Date: Mon, 5 Aug 2024 16:32:28 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Joe Hattori <joe@...is.s.u-tokyo.ac.jp>
Cc: andrew@...n.ch, olteanv@...il.com, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: dsa: bcm_sf2: Fix a possible memory leak in
 bcm_sf2_mdio_register()

On Fri,  2 Aug 2024 17:54:11 +0900 Joe Hattori wrote:
> bcm_sf2_mdio_register() calls of_phy_find_device() and then
> phy_device_remove() in a loop to remove existing PHY devices.
> of_phy_find_device() eventually calls bus_find_device(), which calls
> get_device() on the returned struct device * to increment the refcount.
> The current implementation does not decrement the refcount, which causes
> memory leak.
> 
> This commit adds the missing phy_device_free() call to decrement the
> refcount via put_device() to balance the refcount.

Please add a Fixes tag pointing to the commit where the problem was
introduced and make sure you CC the maintainer of the driver.
-- 
pw-bot: cr