netdev - Re: [PATCH net v2] net: dsa: microchip: Fix Wake-on-LAN check to not return an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5446a293-b5cb-4d1d-b82e-6a63aed03b2a@gmail.com>
Date: Mon, 5 Aug 2024 16:54:15 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Tristram.Ha@...rochip.com, Woojung Huh <woojung.huh@...rochip.com>,
 Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>,
 Vladimir Oltean <olteanv@...il.com>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: dsa: microchip: Fix Wake-on-LAN check to not
 return an error

On 8/5/24 16:52, Tristram.Ha@...rochip.com wrote:
> From: Tristram Ha <tristram.ha@...rochip.com>
> 
> The wol variable in ksz_port_set_mac_address() is declared with random
> data, but the code in ksz_get_wol call may not be executed so the
> WAKE_MAGIC check may be invalid resulting in an error message when
> setting a MAC address after starting the DSA driver.
> 
> Fixes: 3b454b6390c3 ("net: dsa: microchip: ksz9477: Add Wake on Magic Packet support")
> Signed-off-by: Tristram Ha <tristram.ha@...rochip.com>
> Reviewed-by: Oleksij Rempel <o.rempel@...gutronix.de>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian