netdev - Re: [PATCH net,v2] net/smc: add the max value of fallback reason count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cae5795-df27-45b5-9b95-9a5160f6319c@linux.ibm.com>
Date: Mon, 5 Aug 2024 09:53:56 +0200
From: Wenjia Zhang <wenjia@...ux.ibm.com>
To: Zhengchao Shao <shaozhengchao@...wei.com>, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com
Cc: jaka@...ux.ibm.com, alibuda@...ux.alibaba.com, tonylu@...ux.alibaba.com,
        guwen@...ux.alibaba.com, guangguan.wang@...ux.alibaba.com,
        weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net,v2] net/smc: add the max value of fallback reason
 count



On 05.08.24 06:38, Zhengchao Shao wrote:
> The number of fallback reasons defined in the smc_clc.h file has reached
> 36. For historical reasons, some are no longer quoted, and there's 33
> actually in use. So, add the max value of fallback reason count to 36.
> 
> Fixes: 6ac1e6563f59 ("net/smc: support smc v2.x features validate")
> Fixes: 7f0620b9940b ("net/smc: support max connections per lgr negotiation")
> Fixes: 69b888e3bb4b ("net/smc: support max links per lgr negotiation in clc handshake")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
> v2: add fix tag and change max value to 36
> ---
>   net/smc/smc_stats.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/smc/smc_stats.h b/net/smc/smc_stats.h
> index 9d32058db2b5..e19177ce4092 100644
> --- a/net/smc/smc_stats.h
> +++ b/net/smc/smc_stats.h
> @@ -19,7 +19,7 @@
>   
>   #include "smc_clc.h"
>   
> -#define SMC_MAX_FBACK_RSN_CNT 30
> +#define SMC_MAX_FBACK_RSN_CNT 36
>   
>   enum {
>   	SMC_BUF_8K,

It looks good to me!

Reviewed-by: Wenjia Zhang <wenjia@...ux.ibm.com>