netdev - Re: [PATCH net] net: ngbe: Fix phy mode set to external phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e537389-7f4b-4918-9353-09f0e16af9f8@intel.com>
Date: Tue, 6 Aug 2024 13:13:07 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Mengyuan Lou <mengyuanlou@...-swift.com>
CC: <netdev@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net] net: ngbe: Fix phy mode set to external phy

On 8/6/24 10:25, Mengyuan Lou wrote:
> When use rgmmi to attach to external phy, set
> PHY_INTERFACE_MODE_RGMII_RXID to phy drivers.
> And it is does matter to internal phy.
> 

  107│  * @PHY_INTERFACE_MODE_RGMII: Reduced gigabit media-independent 
interface
  108│  * @PHY_INTERFACE_MODE_RGMII_ID: RGMII with Internal RX+TX delay
  109│  * @PHY_INTERFACE_MODE_RGMII_RXID: RGMII with Internal RX delay
  110│  * @PHY_INTERFACE_MODE_RGMII_TXID: RGMII with Internal RX delay

Your change effectively disables Internal Tx delay, but your commit
message does not tell about that. It also does not tell about why,
nor what is wrong in current behavior.

> Fixes: a1cf597b99a7 ("net: ngbe: Add ngbe mdio bus driver.")

This commit indeed has introduced the line you are changing,
but without explanation, this is not a bugfix.

> Signed-off-by: Mengyuan Lou <mengyuanlou@...-swift.com>
> ---
>   drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c b/drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c
> index ba33a57b42c2..be99ef5833da 100644
> --- a/drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c
> +++ b/drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c
> @@ -218,7 +218,7 @@ int ngbe_phy_connect(struct wx *wx)
>   	ret = phy_connect_direct(wx->netdev,
>   				 wx->phydev,
>   				 ngbe_handle_link_change,
> -				 PHY_INTERFACE_MODE_RGMII_ID);
> +				 PHY_INTERFACE_MODE_RGMII_RXID);
>   	if (ret) {
>   		wx_err(wx, "PHY connect failed.\n");
>   		return ret;