netdev - Re: [PATCH net-next v2 02/12] eth: mvpp2: implement new RSS context API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240806071130.5f456ec0@kernel.org>
Date: Tue, 6 Aug 2024 07:11:30 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Edward Cree <ecree.xilinx@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, dxu@...uu.xyz, przemyslaw.kitszel@...el.com,
 donald.hunter@...il.com, gal.pressman@...ux.dev, tariqt@...dia.com,
 willemdebruijn.kernel@...il.com, jdamato@...tly.com,
 marcin.s.wojtas@...il.com, linux@...linux.org.uk
Subject: Re: [PATCH net-next v2 02/12] eth: mvpp2: implement new RSS context
 API

On Tue, 6 Aug 2024 14:28:16 +0100 Edward Cree wrote:
> > Coincidentally, the default also appears exclusive:
> > 
> > 	u32 limit = ops->rxfh_max_context_id ?: U32_MAX;
> > 
> > U32_MAX can't be used, it has special meaning:
> > 
> > #define ETH_RXFH_CONTEXT_ALLOC		0xffffffff  
> 
> Given that both the default and drivers look more reasonable
>  with an exclusive than an inclusive limit (I assume most
>  drivers with a limit will have an N, like mvpp2 does, rather
>  than a MAX), I guess we should change the code to match the
>  doc rather than the other way around.

Somewhat unclear, because context 0 may not count, so to speak.
At least for bnxt using inclusive max context worked well.
But no preference, with the (obvious?) caveat that if we change 
the definition of the field to be exclusive we should rename it.