netdev - Re: [PATCH net-next v2 00/12] ethtool: rss: driver tweaks and netlink context dumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240806072041.06bf085e@kernel.org>
Date: Tue, 6 Aug 2024 07:20:41 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, dxu@...uu.xyz, ecree.xilinx@...il.com,
 przemyslaw.kitszel@...el.com, donald.hunter@...il.com, tariqt@...dia.com,
 willemdebruijn.kernel@...il.com, jdamato@...tly.com, Ahmed Zaki
 <ahmed.zaki@...el.com>
Subject: Re: [PATCH net-next v2 00/12] ethtool: rss: driver tweaks and
 netlink context dumps

On Tue, 6 Aug 2024 15:22:07 +0300 Gal Pressman wrote:
> > I guess we just need to throw "&& !create" into the condition?
> > Sounds good!   
> 
> Yes.
> 
> > We should probably split the "actual invalid" from 
> > the "nothing specified" checks.  
> 
> And make the "no change" check return zero?

My knee jerk reaction would be to keep the error return code.
But I guess one could argue in either direction.

> > Also - curious what you'll put under Fixes, looks like a pretty 
> > ancient bug :)  
> 
> Maybe 84a1d9c48200 ("net: ethtool: extend RXNFC API to support RSS
> spreading of filter matches")?

Nod.