netdev - Re: [PATCH v3 08/12] testing: net-drv: add basic shaper test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240806152158.GZ2636630@kernel.org>
Date: Tue, 6 Aug 2024 16:21:58 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
	Jiri Pirko <jiri@...nulli.us>,
	Madhu Chittim <madhu.chittim@...el.com>,
	Sridhar Samudrala <sridhar.samudrala@...el.com>,
	John Fastabend <john.fastabend@...il.com>,
	Sunil Kovvuri Goutham <sgoutham@...vell.com>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH v3 08/12] testing: net-drv: add basic shaper test

On Mon, Aug 05, 2024 at 12:36:55PM -0700, Jakub Kicinski wrote:
> On Mon, 5 Aug 2024 15:22:53 +0100 Simon Horman wrote:
> > On Wed, Jul 31, 2024 at 06:55:11PM -0700, Jakub Kicinski wrote:
> > > On Wed, 31 Jul 2024 09:52:38 +0200 Paolo Abeni wrote:  
> > > > FTR, it looks like the CI build went wild around this patch, but the 
> > > > failures look unrelated to the actual changes here. i.e.:
> > > > 
> > > > https://netdev.bots.linux.dev/static/nipa/875223/13747883/build_clang/stderr  
> > > 
> > > Could you dig deeper?
> > > 
> > > The scripts are doing incremental builds, and changes to Kconfig
> > > confuse them. You should be able to run the build script as a normal
> > > bash script, directly, it only needs a small handful of exported
> > > env variables.
> > > 
> > > I have been trying to massage this for a while, my last change is:
> > > https://github.com/linux-netdev/nipa/commit/5bcb890cbfecd3c1727cec2f026360646a4afc62
> > >   
> > 
> > Thanks Jakub,
> > 
> > I am looking into this.
> > So far I believe it relate to a Kconfig change activating new code.
> > But reproducing the problem is proving a little tricky.
> 
> Have you tried twiddling / exporting FIRST_IN_SERIES ?
> 
> See here for the 4 possible exports the test will look at:
> 
> https://github.com/linux-netdev/nipa/blob/6112db7d472660450c69457c98ab37b431063301/core/test.py#L124

Thanks, I will look into that.