netdev - Re: [devel-ipsec] [PATCH ipsec-next v8 08/16] xfrm: iptfs: add user packet (tunnel ingress) handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240806152457.GA2636630@kernel.org>
Date: Tue, 6 Aug 2024 16:24:57 +0100
From: Simon Horman <horms@...nel.org>
To: Christian Hopps <chopps@...pps.org>
Cc: Steffen Klassert <steffen.klassert@...unet.com>, netdev@...r.kernel.org,
	Christian Hopps <chopps@...n.net>, devel@...ux-ipsec.org
Subject: Re: [devel-ipsec] [PATCH ipsec-next v8 08/16] xfrm: iptfs: add user
 packet (tunnel ingress) handling

On Tue, Aug 06, 2024 at 06:19:28AM -0400, Christian Hopps wrote:
> 
> Simon Horman via Devel <devel@...ux-ipsec.org> writes:
> 
> > On Sun, Aug 04, 2024 at 04:33:37PM -0400, Christian Hopps wrote:
> > > From: Christian Hopps <chopps@...n.net>
> > > 
> > > Add tunnel packet output functionality. This is code handles
> > > the ingress to the tunnel.
> > > 
> > > Signed-off-by: Christian Hopps <chopps@...n.net>
> > 
> > ...
> > 
> > > +static int iptfs_prepare_output(struct xfrm_state *x, struct sk_buff *skb)
> > > +{
> > > +	if (x->outer_mode.family == AF_INET)
> > > +		return iptfs_encap_add_ipv4(x, skb);
> > > +	if (x->outer_mode.family == AF_INET6) {
> > > +#if IS_ENABLED(CONFIG_IPV6)
> > > +		return iptfs_encap_add_ipv6(x, skb);
> > 
> > iptfs_encap_add_ipv6 is flagged as unused when IPV6 is not enabled.
> > Perhaps it should also be wrapped in a CONFIG_IPV6 check.
> 
> Done, and tested with CONFIG_IPV6=n.

Thanks!