netdev - Re: [PATCH net] net: ethtool: fix off-by-one error in max RSS context IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <242fd732-0962-ef5e-a3fc-fe8007a521f9@gmail.com>
Date: Tue, 6 Aug 2024 17:07:34 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net] net: ethtool: fix off-by-one error in max RSS context
 IDs

On 06/08/2024 17:01, edward.cree@....com wrote:
> From: Edward Cree <ecree.xilinx@...il.com>
> 
> Both ethtool_ops.rxfh_max_context_id and the default value used when
>  it's not specified are supposed to be exclusive maxima (the former
>  is documented as such; the latter, U32_MAX, cannot be used as an ID
>  since it equals ETH_RXFH_CONTEXT_ALLOC), but xa_alloc() expects an
>  inclusive maximum.
> Subtract one from 'limit' to produce an inclusive maximum, and pass
>  that to xa_alloc().  Special-case limit==0 to avoid overflow.
> 
> Fixes: 6603754cd914 ("net: ethtool: let the core choose RSS context IDs")

Whoops, that should have been
Fixes: 847a8ab18676 ("net: ethtool: let the core choose RSS context IDs")